Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collection components #6359

Merged
merged 113 commits into from
Feb 3, 2025
Merged

Add collection components #6359

merged 113 commits into from
Feb 3, 2025
+3,780 −647

Conversation

mohamedsalem401
Copy link
Member

No description provided.

@mohamedsalem401
Add collection component
21a08cc
@mohamedsalem401
Add resolving collection variables
d49cd39
@mohamedsalem401
Allow data-variable paths as a collection's datasource
4aee355
@mohamedsalem401
make collection items undraggable and undroppable
7294394
@mohamedsalem401
Add many info to the currentItem
17b84fb
@mohamedsalem401
fix passing a datasource as collection's datasource
7db4187
@mohamedsalem401
Allow nested collections
09da446
@mohamedsalem401
Fix collection iteration values
2f6f13c
@mohamedsalem401
Fix getting current item
9d142f4
@mohamedsalem401
Use values from the innermost collection instead of the outermost one.
01e81f4
@mohamedsalem401
Throw an error when using the name of a non-existent collection.
4a22be0
@mohamedsalem401
refactor componentCollectionKey
72539f1
@mohamedsalem401
remove circular dependancy
ddab929
@mohamedsalem401
Add start and end index for collections
d631ca7
@mohamedsalem401
Merge branch 'dev' of https://github.com/GrapesJS/grapesjs into colle…
a36aa30 
…ction-component
@mohamedsalem401
use symbols for collection components
050a4cd
@mohamedsalem401
refactor collection symbols
b142b14
@mohamedsalem401
Refactor collections
a1ce18a
@mohamedsalem401
Refactor and format
ed8ecbc
@mohamedsalem401
Refactor collection keys
a1fea6e
@mohamedsalem401
Cleanup collectionStateMap
8c734e2
@mohamedsalem401
Only use 1 symbol to be used for each item in the collections
c6f4ad4
@mohamedsalem401
Fix path for static datasource
8fc9481
@mohamedsalem401
Merge branch 'dev' of https://github.com/GrapesJS/grapesjs into colle…
16f15b8 
…ction-component
@mohamedsalem401
Add collection variables
9837116
@mohamedsalem401
Refactor dynamic component watcher
721f7b0
@mohamedsalem401
Refactor mehods for dynamic value watchers
c123c18
@mohamedsalem401
Bind watcher to component in the constructor
6aa7244
@mohamedsalem401
Move ovveriding collection variables to component watcher
369caed
@mohamedsalem401
Add collection component stringfication
54320d4
mohamedsalem401 and others added 28 commits January 21, 2025 03:27
@mohamedsalem401
Add tests for adding and removing records
1f00f16
@mohamedsalem401
Format
39d6de8
@mohamedsalem401
Fix updating datasource
979d035
@mohamedsalem401
Fix nested symbols not working on collection component
e9b46e7
@mohamedsalem401
Fix syncing collection items for nested collections
c3172a6
@mohamedsalem401
Refactor
dc13e11
@mohamedsalem401
Fix issue on updating collection datasource
84d5aca
@mohamedsalem401
Fix datacollection variable view not updating correctly
a3a9cce
@mohamedsalem401
Fix issue after dragging and then cloning a collection variable
0cd443d
@mohamedsalem401
Fix tests
45348ee
@mohamedsalem401
Merge branch 'dev' of https://github.com/GrapesJS/grapesjs into colle…
59d1045 
…ction-component
@mohamedsalem401
Add testing data collection component variable HTML element
8a4db7d
@mohamedsalem401
Update the logic for getComponentDef
214f425
@mohamedsalem401
Fallback to keyCollectionDefinition if no collection items were found
acbd15c
@artf
Add collection model/view check
3f4d138
@mohamedsalem401
Fix updating records issue
aab824f
@artf
Refactoring
9040859
@artf
Move data components view
fb94416
@artf
Update DynamicVariableListenerManager
bec5d23
@artf
Cleanup
f60840c
@artf
Up DataCondition
7666ce3
@artf
Small refactor
cdba6ac
@artf
Refactor to data resolvers
ea4a9a8
@artf
Use dataResolverWatchers
414f9bb
@artf
Up ComponentDataCollection
dfb815c
@artf
Up reset
f02a1e6
@artf
Updata ComponentDataVariable
ef2bbfb
@artf
Up ComponentDataCollectionVariable
29c85e2
@artf artf merged commit d629989 into dev Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artf artf artf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamedsalem401 @artf